Bug: Fix the layout commands #4

New Issue

Ambroise · 2023-06-20T17:51:28Z

Ambroise commented

2023-06-20 17:51:28 +00:00

Description of the problem

There is a bug in the thesis class for the layout commands like \horizontalmarginsvalue.
Indeed, calling them does not actually change the layout since the if conditions that sets the margin values and the \checkandfixthelayout command are only executed at loading time. Thus changing any value in the preamble will have no effect whatsoever.

Proposed solution

The margin values should be passed as parameters to the class so that they can be set directly.
Additionally, the other commands should force a call to the command to fix the layout.

# Description of the problem There is a bug in the thesis class for the [layout commands](https://git.tigrau.ovh/Ambroise/LaTeX-Templates/src/branch/master/York-Thesis/yorkthesis.cls#L72-L75) like `\horizontalmarginsvalue`. Indeed, calling them does not actually change the layout since the if conditions that sets the margin values and the `\checkandfixthelayout` command are [only executed at loading time](https://git.tigrau.ovh/Ambroise/LaTeX-Templates/src/branch/master/York-Thesis/yorkthesis.cls#L77-L97). Thus changing any value in the preamble will have no effect whatsoever. # Proposed solution The margin values should be passed as parameters to the class so that they can be set directly. Additionally, the other commands should force a call to the command to fix the layout.

Ambroise added the

bug

Thesis

labels 2023-06-20 17:51:28 +00:00

Ambroise changed title from ~~Fix the layout commands~~ to Bug: Fix the layout commands

2023-09-12 10:42:15 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Ambroise/LaTeX-Templates#4